feat: support indexing in mixed discrete-continuous systems #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baggepinnen
reviewed
Mar 7, 2024
src/parameter_indexing.jl
Outdated
|
|
||
| Return an indexable collection containing the value of all parameters in `p` at time index | ||
| `t`. This is useful when parameter values change during the simulation | ||
| (such as through callbacks) and their values are saved. `t` is the time index in the |
There was a problem hiding this comment.
tis the time index
This sounds ambiguous, is t time or index?
If it's an index, perhaps we could clarify by calling it ti and say that it's an integer?
There was a problem hiding this comment.
I'll refactor it to be i, since that's what we use for time index elsewhere. The only difference is it's the time index in the parameter timeseries
src/parameter_indexing.jl
Outdated
| parameter_values_at_state_time(p, t) | ||
|
|
||
| Return an indexable collection containing the value of all parameters in `p` at time | ||
| index `t`. This is useful when parameter values change during the simulation (such as |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
===========================================
+ Coverage 0.00% 38.83% +38.83%
===========================================
Files 6 7 +1
Lines 236 291 +55
===========================================
+ Hits 0 113 +113
+ Misses 236 178 -58 ☔ View full report in Codecov by Sentry. |
AayushSabharwal
force-pushed
the
as/discrete-indexing
branch
from
de0ac6e to
e054e16
Compare
AayushSabharwal
force-pushed
the
as/discrete-indexing
branch
from
e054e16 to
728b89a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.