Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix getu with parameter symbols #55

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal marked this pull request as draft March 8, 2024 14:52
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 38.17%. Comparing base (a7c70c8) to head (ad18dbf).

Files Patch % Lines
src/state_indexing.jl 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   38.83%   38.17%   -0.66%     
==========================================
  Files           7        7              
  Lines         291      296       +5     
==========================================
  Hits          113      113              
- Misses        178      183       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal AayushSabharwal marked this pull request as ready for review March 8, 2024 15:31
@ChrisRackauckas ChrisRackauckas merged commit 27df802 into master Mar 9, 2024
9 of 11 checks passed
@ChrisRackauckas ChrisRackauckas deleted the as/getu-param branch March 9, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants