feat: support indexing Tuple parameters, add tests #63
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 7 7
Lines 355 366 +11
======================================
- Misses 355 366 +11 ☔ View full report in Codecov by Sentry. |
|
When would one want to use |
|
No, just allowing the parameter object to be a |
AayushSabharwal
force-pushed
the
as/tuple-parameter-values
branch
from
9f44ea1 to
30b4759
Compare
| else | ||
| mutbuffer = remake_buffer(sys, collect(oldbuffer), vals) | ||
| newbuffer = similar_type(oldbuffer, eltype(mutbuffer))(mutbuffer) | ||
| end | ||
| return newbuffer | ||
| end | ||
|
|
||
| mutable struct TupleRemakeWrapper | ||
| t::Tuple |
There was a problem hiding this comment.
This won't infer, Tuple isn't concrete
There was a problem hiding this comment.
The type of the tuple can change, which is why it's not fully typed
| mutable struct TupleRemakeWrapper | ||
| t::Tuple |
There was a problem hiding this comment.
| mutable struct TupleRemakeWrapper | |
| t::Tuple | |
| mutable struct TupleRemakeWrapper{T <: Tuple} | |
| t::T |
?
|
Let's follow up with the performance bit if it's needed. |
|
This can't really be fully inferred, since
|
|
Gotcha |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.