Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better :convert_comma for CSV Exporter #42

Open
athityakumar opened this issue Jul 30, 2017 · 0 comments
Open

Better :convert_comma for CSV Exporter #42

athityakumar opened this issue Jul 30, 2017 · 0 comments
Labels
enhancement Exporter ready

Comments

@athityakumar
Copy link
Member

As per PR #34, the :convert_comma option when set to true, works with the following -

str =~ /^\d+./ ? str.tr('.',',') : str

This works mostly, but seems a bit fragile and could be more battle-tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Exporter ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@athityakumar