Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disclaimer #89

Merged
merged 1 commit into from
Dec 4, 2024
Merged

disclaimer #89

merged 1 commit into from
Dec 4, 2024

Conversation

natashiab
Copy link
Contributor

  • Created a box with a reminder of getting ethical approval etc to access data on both the Data Sources and the Registries page.
  • Changed so both have the same text in the search bar as it was different

@natashiab natashiab requested a review from SevLG November 27, 2024 13:57
@JanProgrammierung
Copy link
Member

Just went through the PR, the disclaimer looks good and changing the placeholder text to be identical as well.
I saw that you also changed some of the filter functions. Was that on purpose to improve or change how they work?
@natashiab

@natashiab
Copy link
Contributor Author

Thanks for reviewing! I didn't really mean to - but I went through it and the way the filtering options works now is a bit less strict and gives more hits, but maybe we want to stick to how it is on the Data Platform (do we anyway?) and I can remove those parts and push it again.

@JanProgrammierung
Copy link
Member

@natashiab
We don't have the same technology as the Data Platform, so we have our own search functions.
I don't mind updating our functions if they work better and you manually tested that they work. I approve the Pull Request :)

@JanProgrammierung JanProgrammierung self-requested a review November 28, 2024 13:27
@JanProgrammierung JanProgrammierung merged commit bb35a23 into dev Dec 4, 2024
4 checks passed
@JanProgrammierung JanProgrammierung deleted the disclaimer branch December 4, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants