Skip to content

Commit

Permalink
Hotfix/shiny proxy internet egress (#119)
Browse files Browse the repository at this point in the history
  • Loading branch information
hamzaimran08 authored Dec 8, 2023
1 parent 0d27749 commit 3425516
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion charts/apps/shinyproxy/chart/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ data:
id: {{ .Release.Name }}
labels:
sp.instance: {{ .Release.Name }}
alow-api-access: "true"
allow-internet-egress: "true"
shinyproxy-app: {{ .Release.Name }}
kubernetes-pod-patches: |
- op: add
Expand Down
2 changes: 1 addition & 1 deletion charts/apps/shinyproxy/chart/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ spec:
affinity:
{{ .Values.affinity | toYaml | nindent 8 | trim }}
{{ end }}
automountServiceAccountToken: true
serviceAccountName: {{ .Values.namespace }}-shinyproxy
containers:
- name: serve
image: {{ .Values.appconfig.proxyimage }}
Expand Down
2 changes: 1 addition & 1 deletion charts/apps/shinyproxy/chart/templates/hooks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
allow-api-access: "true"
spec:
restartPolicy: Never
serviceAccountName: default
serviceAccountName: {{ .Values.namespace }}-shinyproxy
containers:
- name: delete-user-pods
image: bitnami/kubectl:{{ .Capabilities.KubeVersion.Major }}.{{ .Capabilities.KubeVersion.Minor }}
Expand Down
1 change: 1 addition & 0 deletions charts/apps/shinyproxy/chart/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ metadata:
nginx.ingress.kubernetes.io/auth-url: "{{ .Values.global.protocol }}://{{ .Values.global.auth_domain }}:8080/auth/?release={{ .Values.release }}"
nginx.ingress.kubernetes.io/auth-signin: "https://{{ .Values.global.domain }}/accounts/login/?next=$scheme%3A%2F%2F$host"
{{- end }}
nginx.ingress.kubernetes.io/proxy-body-size: 2000m
#nginx.ingress.kubernetes.io/auth-response-headers: X-Forwarded-Host
spec:
rules:
Expand Down
2 changes: 1 addition & 1 deletion fixtures/objecttype_fixtures.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
{
"fields": {
"app_slug": "fastapi-serve",
"app_slug": "python-serve",
"name": "Python Model Deployment",
"slug": "python"
},
Expand Down
4 changes: 2 additions & 2 deletions fixtures/projects_templates.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"image": "serve-mlflow:231030-1149",
"repository": "ghcr.io/scilifelabdatacentre"
},
"Default Serving": {
"Python Serving": {
"app": "python-serve",
"image": "serve-python:latest",
"repository": "ghcr.io/scilifelabdatacentre"
Expand Down Expand Up @@ -103,7 +103,7 @@
"image": "serve-mlflow:231030-1149",
"repository": "ghcr.io/scilifelabdatacentre"
},
"Default Serving": {
"Python Serving": {
"app": "python-serve",
"image": "serve-python:latest",
"repository": "ghcr.io/scilifelabdatacentre"
Expand Down

0 comments on commit 3425516

Please sign in to comment.