Base58 while loop eats up CPU

[pragmaxim]

It eats up almost 30% of the runtime, taking more time than indexing blocks into database. Completely different implementation com.google.bitcoin.core.Base58 eats up only 7%.

https://github.com/ScorexFoundation/scorex-util/blob/master/shared/src/main/scala/scorex/util/encode/Base58.scala#L22C1-L26

Ping #27

[pragmaxim]

Ok, this implementation of Base58 is extremely slow, com.google.bitcoin.core.Base58 is ~ 3-4 times faster ... After some further optimizations of blockchain explorer indexing, ~ 45% goes to com.google.bitcoin.core.Base58, 15% goes to sigma and 40% to the rest.

[aslesarenko]

Thanks for the flame graphs. This is known issue #21, closing this as duplicate.