Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement latest requested PR changes #12

Open
dbutt-scottlogic opened this issue Apr 28, 2022 · 0 comments
Open

Implement latest requested PR changes #12

dbutt-scottlogic opened this issue Apr 28, 2022 · 0 comments
Assignees

Comments

@dbutt-scottlogic
Copy link

dbutt-scottlogic commented Apr 28, 2022

  1. Tests which handle FDC3 errors are assuming that they are strings (this is how Finsemble raises them, but is wrong). So instead of (for example) ex !== ResolveError.NoAppsFound we should have ex.message !== ResolveError.NoAppsFound.
    a. fdc3.findIntent.ts
    b. fdc3.findIntentsByContext.ts
    c. fdc3.open.ts
    d. fdc3.raiseIntent.ts
    e. fdc3.raiseIntentForContext.ts
  2. Move the appDefinition.json file out of the src dir and into the root of the project and update the README.md to match.
  3. Where the tests themselves raise exceptions, these should be raised as Errors not strings, i.e. throw new Error(ExpectedErrorNotThrownError);
    a. fdc3.joinChannel.ts
    b. fdc3.open.ts
    c. fdc3.findIntentsByContext.ts
    d. fdc3.raiseIntent.ts
    e. fdc3.raiseIntentForContext.ts
  4. The icon in appdefinition.json could the changed to the icon http://fdc3.finos.org/toolbox/fdc3-workbench/fdc3-icon-256.png (copy it into the project).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants