Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-based integration with obsidian-icon-folder plugin #65

Open
SebastianMC opened this issue Mar 1, 2023 · 1 comment
Open

API-based integration with obsidian-icon-folder plugin #65

SebastianMC opened this issue Mar 1, 2023 · 1 comment
Labels
enhancement New feature or request on hold Paused - will be resumed or cancelled.

Comments

@SebastianMC
Copy link
Owner

SebastianMC commented Mar 1, 2023

Under #60 the basic integration with obsidian-icon-folder plugin was introduced.
The connection between the plugins is based on direct access to internal data of the obsidian-icon-folder plugin. That's a reason why the integration is limited: only icons configured directly on folders and files are considered, ignoring the inherited or regexp-applied icons. Also, such kind of integration introduces a tight-coupling: if the obsidian-icon-folder plugin changes its internal data structures, the integration will no longer work.

To address this long term an explicit request to the author of obsidian-icon-folder was supplied:

If the above ticket is completed, the integration can be switched to be API-based, and in result:

  • handle all methods of applying icon to folders and notes
  • be shielded from changes of implementation of obsidian-icon-folder
@SebastianMC SebastianMC changed the title API-based integration with obsidian-icon-folder API-based integration with obsidian-icon-folder plugin Mar 1, 2023
@SebastianMC SebastianMC added on hold Paused - will be resumed or cancelled. enhancement New feature or request labels Mar 1, 2023
@replete
Copy link

replete commented Mar 9, 2023

I just wanted to say that I've had no conflicts between with your plugin and obsidian-icon-folders.

I've had problems with obsidian-icon-folders losing my icon assignments unexpectedly. It's happened a few times and I'm expecting it to happen again with some other plugin update. If/when your plugin supports setting icons by sortspec, I will definitely switch over because its such a waste of time re-assigning icons.

Great work on this plugin.

SebastianMC pushed a commit that referenced this issue Sep 26, 2023
- remove header in settings
- remove logging of changed settings value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on hold Paused - will be resumed or cancelled.
Projects
None yet
Development

No branches or pull requests

2 participants