Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Wire.requestFrom should not be encapsulated by Wire.beginTransmission or Wire.endTransmission. #2

Closed
Koepel opened this issue Apr 17, 2017 · 2 comments
Assignees
Labels
NFC_Tag_M24LR6E Label for NFC_Tag_M24LR6E UAY Unassigned yet

Comments

@Koepel
Copy link

Koepel commented Apr 17, 2017

In the file NfcTag.cpp, in the functions _EEPROM_Read_Byte and _EEPROM_Read_Bytes, there is a Wire.beginTransmission before the Wire.requestFrom and a Wire.endTransmission after it.

Those Wire.beginTransmission and Wire.endTransmission can be removed, they should only be used when writing data.

@MatthewJeffson MatthewJeffson added UAY Unassigned yet NFC_Tag_M24LR6E Label for NFC_Tag_M24LR6E labels Oct 9, 2024
@Lesords Lesords self-assigned this Oct 15, 2024
@Lesords
Copy link
Contributor

Lesords commented Oct 16, 2024

Hello,

I'm very sorry to have kept you waiting so long.

There is a PR that solves this problem. I will review and merge it as soon as possible.

@Lesords
Copy link
Contributor

Lesords commented Oct 16, 2024

Done,

I'm going to close this issue, feel free to re-open it if you have any other questions.

@Lesords Lesords closed this as completed Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PR Assemble Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NFC_Tag_M24LR6E Label for NFC_Tag_M24LR6E UAY Unassigned yet
Projects
Status: Done
Development

No branches or pull requests

3 participants