Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Downgrade steep to 1.5.2 to avoid issues on windows based pipelines #14790

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

aguspe
Copy link
Contributor

@aguspe aguspe commented Nov 22, 2024

Description

Steep 1.5.3 depends on Active support which depends on Ruby 3.2.0 and this is causing issues on our pipelines for all of our windows based tests

The error message on our pipeline:

steep (~> 1.5.0) mri, mingw, x64_mingw was resolved to 1.5.3, which depends on activesupport (>= 5.1) was resolved to 8.0.0, which depends on Ruby\0 (>= 3.2.0)

Motivation and Context

It is important that we have pipelines executing correctly and not being broken by dependencies

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

dependencies


Description

  • Downgraded the steep gem version in the Gemfile from ~> 1.5.0 to 1.5.2 to address compatibility or stability issues.

Changes walkthrough 📝

Relevant files
Dependencies
Gemfile
Downgrade `steep` gem version to 1.5.2                                     

rb/Gemfile

  • Downgraded the steep gem version from ~> 1.5.0 to 1.5.2.
+1/-1     

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Lock
Pinning to exact version 1.5.2 removes flexibility for patch updates that could include important bug fixes. Consider if using '~> 1.5.2' would be more appropriate to allow patch updates while maintaining compatibility

Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
General
Use version constraint operator to allow compatible updates while maintaining stability

Use the pessimistic version operator (~>) to allow for compatible minor version
updates of the steep gem while preventing major version changes that could break
functionality.

rb/Gemfile [10]

-gem 'steep', '1.5.2', require: false, platforms: %i[mri mingw x64_mingw]
+gem 'steep', '~> 1.5.2', require: false, platforms: %i[mri mingw x64_mingw]
  • Apply this suggestion
Suggestion importance[1-10]: 7

Why: Using the pessimistic version operator (~>) is a Ruby best practice that allows for safe patch-level updates while preventing potentially breaking changes. This suggestion would improve dependency management flexibility and maintainability.

7

💡 Need additional feedback ? start a PR chat

@aguspe aguspe changed the title Downgrade steep to 1.5.2 [rb] Downgrade steep to 1.5.2 to avoid issues on windows based pipelines Nov 22, 2024
@aguspe aguspe merged commit 4b7d174 into SeleniumHQ:trunk Nov 22, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant