Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create mock for the huggingface embedding model in all tests #11

Open
MAfarrag opened this issue Feb 5, 2025 · 0 comments
Open

Create mock for the huggingface embedding model in all tests #11

MAfarrag opened this issue Feb 5, 2025 · 0 comments
Labels
enhancement New feature or request testing improve testing, conver missing lines

Comments

@MAfarrag
Copy link
Member

MAfarrag commented Feb 5, 2025

  • The following tests uses the HuggingFaceEmbedding class that download embedding model from huggingface, and the download takes time which make testing takes longer time.

Tests

  • tests/utils/test_config_loader.py::test_config_loader
  • tests/indexing/test_custom_index.py::TestProperties::test_embedding_model
  • tests/utils/test_models.py::test_embedding

What is needed

Create mock for the HuggingFaceEmbedding class or the returned value from constructing the object so that the test does not actually trigger the download.
@MAfarrag MAfarrag added enhancement New feature or request testing improve testing, conver missing lines labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request testing improve testing, conver missing lines
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MAfarrag