Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-tcp): add serverlessly protocol tcp 🚧 #30

Closed
wants to merge 1 commit into from

Conversation

SachinShekhar
Copy link
Member

This Pull Request implements TCP as described in #2.

Closes #2

  • I have read CONTRIBUTING guide.
  • I have added necessary tests.
  • I have added necessary docs.
  • I have run yarn test && yarn lint && yarn format.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license

@codeclimate
Copy link

codeclimate bot commented Dec 27, 2020

Code Climate has analyzed commit fc6abe3 and detected 0 issues on this pull request.

View more on Code Climate.

@mergify mergify bot added critical-package An important package which needs extra care by-core-team PR author is someone from core team work-in-progress work is in progress untested-code Coverage isn't 100% labels Dec 27, 2020
@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #30 (fc6abe3) into main (407f523) will decrease coverage by 27.27%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##              main      #30       +/-   ##
============================================
- Coverage   100.00%   72.72%   -27.28%     
============================================
  Files            6       10        +4     
  Lines           64       88       +24     
  Branches         7       10        +3     
============================================
  Hits            64       64               
- Misses           0       23       +23     
- Partials         0        1        +1     
Impacted Files Coverage Δ
@serverlessly/protocol-tcp/index.ts 0.00% <0.00%> (ø)
...serverlessly/protocol-tcp/lib/middleware-engine.ts 0.00% <0.00%> (ø)
@serverlessly/protocol-tcp/lib/server-factory.ts 0.00% <0.00%> (ø)
@serverlessly/protocol-tcp/lib/tcp.ts 0.00% <0.00%> (ø)

@SachinShekhar
Copy link
Member Author

With complete overhaul of core system (#94), it's better to rewrite protocol-tcp from scratch.

@mergify mergify bot added the rejected PR was rejected (no merge) label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by-core-team PR author is someone from core team critical-package An important package which needs extra care rejected PR was rejected (no merge) @serverlessly/protocol-tcp untested-code Coverage isn't 100% work-in-progress work is in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protocol: tcp
1 participant