Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat API improvement #99

Open
gasse opened this issue Jul 19, 2024 · 0 comments
Open

Chat API improvement #99

gasse opened this issue Jul 19, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gasse
Copy link
Collaborator

gasse commented Jul 19, 2024

What we want

The current chat API is not super modular. Ideally we would like to be able to switch between different chat implementations, which can be parameterized via an argument in BrowserEnv's __init__().

  • the current chat implementation, a dynamic chat webpage handled in a Playwright context
  • a hidden chat, it can receive messages from the task and the agent but there is no display
  • a chat implemented via a Chrome extension?
  • any chat that users can implement, following a pre-defined API

How

Several things need to be done

  • a new AbstractChat class with abstract methods add_message(), wait_for_user_message() and close() (could be refactored as well)
  • the current chat would be renamed PlaywrightChat or something, and inherit from the AbstractChat class
  • the way the chat is exposed to cheat functions has to be adapted as well (see Cheat API improvements #78 )
@gasse gasse added enhancement New feature or request good first issue Good for newcomers labels Jul 19, 2024
@gasse gasse changed the title Generic Chat API Chat API improvement Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant