Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature request] - Add ability to toggle "Selected polities" and "Base map" #145

Open
7 tasks
jennyreddish opened this issue Nov 12, 2024 · 0 comments
Open
7 tasks
Assignees

Comments

@jennyreddish
Copy link

jennyreddish commented Nov 12, 2024

Description of Improvement

On the world map, when you click on polities, their names and colours are shown in a box on the bottom right called "Selected Polities". Is it possible to add checkboxes that allow the user to toggle these and the base map to show only the polities they're interested in for a specific year? E.g. if I want to compare the Parthian Empire and Han Dynasty in 100 CE, I could select those and uncheck the base map, giving a clean look. Not a priority by any means, but might be a nice feature!

Dependencies

No response

Technical Notes

TODO:

  • Add minus buttons to Selected polities legend to remove highlights
  • Clicking the minus button for "Base map" when "Clickable borders" is set on the Background map radio switches it to "Basic unlabelled"
  • Add a new button called "Hide unselected" which removes all polities that aren't selected from the map
  • Add another new button that does "Select all" which will highlight all polities (and add them all to the legend)

Definition of Done

  • The feature has been developed on a feature branch.
  • The feature branch has been tested in the Staging website.
  • A pull request has been created for the feature branch to be merged into the dev branch.
@edwardchalstrey1 edwardchalstrey1 self-assigned this Nov 12, 2024
@kallewesterling kallewesterling changed the title ✨ [Feature request] - <Toggle "Selected polities" and "Base map"> ✨ [Feature request] - Add ability to toggle "Selected polities" and "Base map" Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants