Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.2 - keep_query_string migration #117

Open
stefandoorn opened this issue Nov 27, 2023 · 3 comments
Open

2.2 - keep_query_string migration #117

stefandoorn opened this issue Nov 27, 2023 · 3 comments

Comments

@stefandoorn
Copy link
Contributor

Hi,

From version 2.2.0 the column keep_query_string is added to the database. The plugin doesn't provide a migration for that, though. It would be great to have migration support available, so it automatically updates like Sylius itself does.

Thanks!

Sorry - no time to PR it myself at the moment, so filing it here as a suggestion.
@loevgaard
Copy link
Member

I am more or less against third party migrations, so that won't happen unfortunately :(

@stefandoorn
Copy link
Contributor Author

Then maybe a comment in an upgrade / release notes?

@loevgaard
Copy link
Member

Yes, that would be great to have, I agree! Will reopen the issue :)

@loevgaard loevgaard reopened this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@loevgaard @stefandoorn