Minor fixes

Author: Zales0123

composer.json

@@ -92,7 +92,6 @@
     "autoload-dev": {
         "psr-4": {
             "Setono\\SyliusMeilisearchPlugin\\Tests\\": "tests/",
-            "TestApp\\": "tests/Application/src/"
         },
         "classmap": [
             "tests/Application/Kernel.php"

src/Document/Metadata/Metadata.php

@@ -57,9 +57,8 @@ private function load(): void
         }
     }
 
-    private function loadAttributes(
-        \ReflectionProperty|\ReflectionMethod $attributesAware,
-    ): void {
+    private function loadAttributes(\ReflectionProperty|\ReflectionMethod $attributesAware): void
+    {
         $name = self::resolveName($attributesAware);
         if (null === $name) {
             return;

src/Form/Builder/RangeFacetFormBuilder.php

@@ -25,21 +25,6 @@ public function build(FormBuilderInterface $builder, string $name, array $values
 
     public function supports(string $name, array $values, Facet $facet, array $stats = null): bool
     {
-        if ($facet->type !== 'float') {
-            return false;
-        }
-
-//        $keys = array_keys($values);
-//        if (count($keys) < 2) {
-//            return false;
-//        }
-//
-//        foreach ($keys as $key) {
-//            if (is_numeric($key)) {
-//                return false;
-//            }
-//        }
-
-        return true;
+        return $facet->type === 'float';
     }
 }

src/Meilisearch/Builder/CompositeFilterBuilder.php

@@ -6,12 +6,9 @@
 
 final class CompositeFilterBuilder implements FilterBuilderInterface
 {
-    /**
-     * @param iterable<FilterBuilderInterface> $filterBuilders
-     */
-    public function __construct(
-        private readonly iterable $filterBuilders,
-    ) {
+    /** @param iterable<FilterBuilderInterface> $filterBuilders */
+    public function __construct(private readonly iterable $filterBuilders)
+    {
     }
 
     public function build(array $facets, array $facetsValues): array

tests/Application/config/services.yaml

@@ -2,8 +2,3 @@
 # https://symfony.com/doc/current/best_practices/configuration.html#application-related-configuration
 parameters:
     locale: en_US
-
-services:
-    _defaults:
-        autowire: true      # Automatically injects dependencies in your services.
-        autoconfigure: true # Automatically registers your services as commands, event subscribers, etc.

tests/Unit/Meilisearch/Builder/CompositeFilterBuilderTest.php

@@ -15,11 +15,9 @@ public function test_it_returns_filters(): void
     {
         $brandFilterBuilder = $this->createMock(FilterBuilderInterface::class);
         $brandFilterBuilder->method('build')->willReturn(['(brand = "brand1")']);
-        $brandFilterBuilder->method('supports')->willReturn(true);
 
         $sizeFilterBuilder = $this->createMock(FilterBuilderInterface::class);
         $sizeFilterBuilder->method('build')->willReturn(['(size = "size1" OR size = "size2")']);
-        $sizeFilterBuilder->method('supports')->willReturn(true);
 
         $compositeFilterBuilder = new CompositeFilterBuilder([$brandFilterBuilder, $sizeFilterBuilder]);
 
@@ -37,29 +35,4 @@ public function test_it_returns_filters(): void
             '(size = "size1" OR size = "size2")',
         ], $filters);
     }
-
-    public function test_it_uses_only_supported_filter_builders(): void
-    {
-        $brandFilterBuilder = $this->createMock(FilterBuilderInterface::class);
-        $brandFilterBuilder->expects($this->never())->method('build');
-        $brandFilterBuilder->method('supports')->willReturn(false);
-
-        $sizeFilterBuilder = $this->createMock(FilterBuilderInterface::class);
-        $sizeFilterBuilder->method('build')->willReturn(['(size = "size1" OR size = "size2")']);
-        $sizeFilterBuilder->method('supports')->willReturn(true);
-
-        $compositeFilterBuilder = new CompositeFilterBuilder([$brandFilterBuilder, $sizeFilterBuilder]);
-
-        $onSaleFacet = new Facet('onSale', 'bool');
-        $sizeFacet = new Facet('size', 'string');
-
-        $filters = $compositeFilterBuilder->build(
-            ['onSale' => $onSaleFacet, 'size' => $sizeFacet],
-            ['onSale' => true, 'size' => ['size1', 'size2']],
-        );
-
-        $this->assertSame([
-            '(size = "size1" OR size = "size2")',
-        ], $filters);
-    }
 }