Variant field autocomplete + remove item bug fix #28
Conversation
Zales0123
force-pushed
the
27-variant-field-autocomplete
branch
from
0259e08 to
bdbe858
Compare
| ->add('variant', EntityType::class, [ | ||
| 'class' => ProductVariant::class, | ||
| 'choice_label' => 'code', | ||
| ->add('variant', ResourceAutocompleteChoiceType::class, [ |
There was a problem hiding this comment.
Does this search in id, code, and name as stated in the issue?
There was a problem hiding this comment.
It searches by descriptor, which is code or name, as far as I know. Is the ID search a hard requirement? 😅 It's of course possible, but it would require from us to create a new repository function + new repository configuration and trait to implement it in the final application + new route. It's just easier this way and (I believe, correct me if I'm wrong) searching by name or code is much more useful than by id 🖖
There was a problem hiding this comment.
Okay. Let's just keep it this way for now :D
Zales0123
force-pushed
the
27-variant-field-autocomplete
branch
from
bdbe858 to
1a3d954
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
============================================
+ Coverage 74.10% 74.31% +0.21%
Complexity 71 71
============================================
Files 28 28
Lines 363 366 +3
============================================
+ Hits 269 272 +3
Misses 94 94 ☔ View full report in Codecov by Sentry. |
Zales0123
force-pushed
the
27-variant-field-autocomplete
branch
from
1a3d954 to
1a98ece
Compare
Zales0123
force-pushed
the
27-variant-field-autocomplete
branch
from
1a98ece to
2609a96
Compare
Based on #26
Fixes #27
Nagranie.z.ekranu.2024-06-27.o.12.49.26.mov