Additional installation step on Sylius 1.10 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
=========================================
Coverage 74.31% 74.31%
Complexity 71 71
=========================================
Files 28 28
Lines 366 366
=========================================
Hits 272 272
Misses 94 94 ☔ View full report in Codecov by Sentry. |
loevgaard
reviewed
Aug 9, 2024
loevgaard
approved these changes
Aug 9, 2024
Zales0123
force-pushed
the
missing-route-on-sylius-1-10
branch
from
4c31f46 to
1669261
Compare
loevgaard
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the easiest way to solve #32
We could in theory play with some custom route loader, but IMO it's not worth it. It's only one more step of installation and makes it explicitly what is needed to make the plugin work in 1.10 🖖
Btw, maybe it's worth having at least one job running Sylius 1.10 if we see such problems? 🤔 Something to think about