-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base classes for Off Policy Agents #169
Comments
There's also a lot of code duplication issues that show up pylint. Maybe work on that too. |
Yup, that's the goal. Another thing to do would be properly decide the parameters to be kept/removed in agents and added/removed from the trainers. |
Since we already have the On Policy Agents, I'm renaming this to Off Policy. I'll raise a PR for this soon. |
I'm thinking of refactoring each of the individual off policy algorithms first so that the code is neater, more uniform and shorter. |
To-do:
|
This should make the code much more comprehensible, especially with the number of arguments we have. And at the same time resolve a lot of maintainability issues.
The text was updated successfully, but these errors were encountered: