Skip to content

Commit fcbfc39

Browse files
authored
Merge pull request #37 from Sheldenburg/bug/fix-set-cookies
fix set_cookies in login.py
2 parents b75b082 + fe3190f commit fcbfc39

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

backend/src/app/api/routes/login.py

+9-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def login_google():
132132
google_auth_url = (
133133
"https://accounts.google.com/o/oauth2/v2/auth?"
134134
f"client_id={settings.GOOGLE_CLIENT_ID}&"
135-
"redirect_uri={settings.GOOGLE_REDIRECT_URI}&"
135+
f"redirect_uri={settings.GOOGLE_REDIRECT_URI}&"
136136
"response_type=code&"
137137
"scope=email profile"
138138
)
@@ -178,6 +178,8 @@ def google_oauth(session: SessionDep, code: str, response: Response):
178178
user.id, expires_delta=access_token_expires
179179
),
180180
httponly=True,
181+
secure=True,
182+
samesite="None",
181183
)
182184
return response
183185

@@ -204,6 +206,8 @@ def google_oauth(session: SessionDep, code: str, response: Response):
204206
key="access_token",
205207
value=security.create_access_token(user.id, expires_delta=access_token_expires),
206208
httponly=True,
209+
secure=True,
210+
samesite="None",
207211
)
208212
return response
209213

@@ -248,6 +252,8 @@ def github_oauth(session: SessionDep, code: str, response: Response):
248252
user.id, expires_delta=access_token_expires
249253
),
250254
httponly=True,
255+
secure=True,
256+
samesite="None",
251257
)
252258
return response
253259

@@ -274,5 +280,7 @@ def github_oauth(session: SessionDep, code: str, response: Response):
274280
key="access_token",
275281
value=security.create_access_token(user.id, expires_delta=access_token_expires),
276282
httponly=True,
283+
secure=True,
284+
samesite="None",
277285
)
278286
return response

0 commit comments

Comments
 (0)