Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up prefer_system and prefer_system_check #49

Open
olantwin opened this issue May 5, 2020 · 6 comments
Open

Clean up prefer_system and prefer_system_check #49

olantwin opened this issue May 5, 2020 · 6 comments

Comments

@olantwin
Copy link
Contributor

olantwin commented May 5, 2020

Following on in discussion in #45.

For many packages these are completely outdated.

  • slc5 can be dropped
  • slc6 maybe as well
  • Maybe we can add ubuntu/fedora where appropriate.

For the checks, they are currently very hard to read, so we could make use of YAML multi-line values to make them easier to follow and modify (see e.g. cleanup in #48 )

@olantwin
Copy link
Contributor Author

olantwin commented May 5, 2020

Documentation of prefer_system:

prefer_system: a regular expression for architectures which should use the prefer_system_check by default to determine if the system version of the tool can be used. When the rule matches, the result of prefer_system_check determines whether to build the recipe. When the rule does not match, the check is skipped and the recipe is run. Using the switch --always-prefer-system runs the check always (even when the regular expression for the architecture does not match).

@olantwin
Copy link
Contributor Author

olantwin commented May 5, 2020

@ThomasRuf : what does the architecture string look like for ubuntu? You can find it in e.g. the subdirectory of sw/ containing the built packages.

@ThomasRuf
Copy link
Collaborator

ubuntu2004_x86-64

@olantwin
Copy link
Contributor Author

olantwin commented May 5, 2020

Easiest would probably be to have .* for all packages where we want to check the system, and then exclude individual architectures as needed.

Currently playing around in https://regex101.com/ (using the Python regex setting) to test a few options. I think there might actually be a bug in the (?!slc5|slc6) regex, as it seems to match even slc5 and slc6...

Here the architecture formats I am aware of:

fedora31_x86-64
fedora30_x86-64
slc7_x86-64
slc6_x86-64
slc5_x86-64
ubuntu2004_x86-64

@ThomasRuf
Copy link
Collaborator

What would be against the opposite approach, exclude only OS which we know don't work?

@olantwin
Copy link
Contributor Author

olantwin commented May 5, 2020

Sorry if I was unclear, but that was what I was suggesting (and I think is also what (?!slc5) was supposed to accomplish).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants