Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add support for "metafile" esbuild option #4827

Open
patryk-smc opened this issue Nov 11, 2024 · 2 comments
Open

[Feature]: Add support for "metafile" esbuild option #4827

patryk-smc opened this issue Nov 11, 2024 · 2 comments
Labels
Area: @shopify/app @shopify/app package issues Type: Enhancement New feature or request

Comments

@patryk-smc
Copy link

What area(s) will this request affect?

App, Extension

What type of change do you want to see?

Substantial change to existing feature

Overview

Metafiles are useful for analyzing esbuild bundles. It would be nice to be able to have them generated automatically when running shopify app build or with a cli flag, so they can be uploaded to esbuild bundle analyzer.

Motivation

Reducing bundle size of UI extensions for better performance.

@patryk-smc patryk-smc added the Type: Enhancement New feature or request label Nov 11, 2024
@frandiox
Copy link
Contributor

Hi 👋

Are you using the Remix template with Vite? If so, Vite uses Rollup for bundling instead of ESBuild, so it can't generate an ESBuild metafile by default. For now, you can try with this Rollup/Vite plugin to get something similar: https://github.com/btd/rollup-plugin-visualizer

@frandiox frandiox added the Area: @shopify/app @shopify/app package issues label Nov 12, 2024
@patryk-smc
Copy link
Author

Hi @frandiox , no I don't use Remix template. I only need it for extensions, which looking at the CLI source are built with esbuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/app @shopify/app package issues Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants