Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor slider component #2057

Open
metamoni opened this issue Oct 20, 2022 · 2 comments
Open

Refactor slider component #2057

metamoni opened this issue Oct 20, 2022 · 2 comments
Labels
Category: Tech Debt Opportunities to refactor or improve the code and/or development workflow

Comments

@metamoni
Copy link
Contributor

metamoni commented Oct 20, 2022

Following a bug where the "Add to cart" button was disabled when the media position changes to "Right", we noticed that the slider component needs some refactoring.

See original comment posted by @ludoboludo in #2053 (comment)_

I guess ideally the right media column would never be a <slider-component>. Only the thumbnails get to be a slider if the desktop layout is set to thumbnail carousel which shouldn't impact the media gallery.
Though that would mean a lot of rework and CSS styling tweak most likely.

@metamoni metamoni added the Category: Tech Debt Opportunities to refactor or improve the code and/or development workflow label Oct 20, 2022
@Vortify-tech
Copy link

I have a Dawn theme version 15.2.0 , I added the the option value next to the option name as : Color: red issue is that when i am changing the variant the selected value doesn't change it value until i refresh the page, I uses the attribute data-selected-value in span but this is not working.

Here is my Added attribute:

{{ option.name }}: {{ option.selected_value }}
{% render 'product-variant-options', product: product, option: option, block: block %}

Why the value is not changing on spot?

@uniforx
Copy link

uniforx commented Nov 13, 2024

In addition .. if the variant changes, the custom liquids based on the variant won´t update.

I found a fix for this in an older version of Dawn for myself https://community.shopify.com/c/technische-fragen-antworten/must-reload-product-page-after-changing-variant/m-p/1735157#M18774
BUT this should be fixed for all in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Tech Debt Opportunities to refactor or improve the code and/or development workflow
Projects
None yet
Development

No branches or pull requests

3 participants