Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick order list: quantity that doesn't not respect quantity limit can be added to cart #2857

Open
nicklepine opened this issue Jul 17, 2023 · 3 comments

Comments

@nicklepine
Copy link

nicklepine commented Jul 17, 2023

Meli's video: https://screenshot.click/17-43-5mgav-rzrde.mp4

Slack thread: https://shopify.slack.com/archives/C04NPNBGU87/p1689619584764189

There are 2 bugs - probably related:

  1. Hitting enter after inputing quantity on quick order list on a product that has 1 or zero variants redirects to /cart
  2. I am able to add submit quantity that does not respect quantity limits (bug video)

I think the fix should include::

  • Let's prevent being able to submit a quantity that doesn't respect quantity limits.
  • Let's only suppress cart notification actions on quick order list when there are 2+ variants on a product. For products with zero or 1 variant, let's respect the cart notification behaviour selected in theme settings on quick order list (removed this requirement, see this comment.
  • Hitting "Return/Enter" keyboard key when a product has zero or 1 variant should not bring you to /cart (unless that's your selected cart notification behaviour)

Video recap: https://screenshot.click/17-29-afrh6-clay1.mp4

@nicklepine nicklepine changed the title Quantity that doesnt not respect quantity limit can be added to cart Quick order list: quantity that doesn't not respect quantity limit can be added to cart Jul 17, 2023
@sofiamatulis sofiamatulis self-assigned this Jul 18, 2023
@lucianosousa
Copy link
Member

I am working with the cart team in this ticket.
My PR opened the discussion about how this could be fixed and cart team is taking from there.

Most likely, the fix will come from this PR
I will keep eyes close to it

@thagxt
Copy link

thagxt commented Sep 15, 2023

Hey, @lucianosousa While you are working on that can you also look at this issue: #2994 it is affecting all themes not just Dawn.

@lucianosousa
Copy link
Member

@thagxt can you take a look at this spin instance

I think I solved it too

@lucianosousa lucianosousa removed their assignment Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants