Update translations: merchant #3404
Conversation
![translation-platform[bot]](https://avatars.githubusercontent.com/in/7649?s=60&v=4){kind=small}
|
🕐 This PR has been open for 2 days now 🕐 It is best to merge it as soon as possible in order to avoid having to deal with merge conflicts. More importantly, the content here really wants to reach production so everyone can benefit from it. It is your responsibility to merge this PR once you've reviewed it. 🙏 💚 |
|
🕐 This PR has been open for 4 days now 🕐 It is best to merge it as soon as possible in order to avoid having to deal with merge conflicts. More importantly, the content here really wants to reach production so everyone can benefit from it. It is your responsibility to merge this PR once you've reviewed it. 🙏 💚 |
|
🕐 This PR has been open for 7 days now 🕐 It is best to merge it as soon as possible in order to avoid having to deal with merge conflicts. More importantly, the content here really wants to reach production so everyone can benefit from it. It is your responsibility to merge this PR once you've reviewed it. 🙏 💚 |
| @@ -610,7 +610,7 @@ | |||
| "label": "Muotokuva" | |||
| }, | |||
| "options__3": { | |||
| "label": "Neliö" | |||
| "label": "Square" | |||
There was a problem hiding this comment.
It looks like we are still getting this issue 🤔 @ludoboludo I see your comment above. Do you have context on next steps?
There was a problem hiding this comment.
I had shared the issue with the localization team and they were looking into it. I followed up with them today to mention that it's still an issue 👍
| @@ -610,7 +610,7 @@ | |||
| "label": "Muotokuva" | |||
| }, | |||
| "options__3": { | |||
| "label": "Neliö" | |||
| "label": "Square" | |||
There was a problem hiding this comment.
I think this is still not supposed to be that way. Shouldn't be the english word for it.
locales/fr.schema.json
Outdated
| @@ -1659,7 +1659,7 @@ | |||
| "label": "Cercle" | |||
| }, | |||
| "options__2": { | |||
| "label": "Carré" | |||
| "label": "Square" | |||
There was a problem hiding this comment.
Same here, should be Carré
locales/fr.schema.json
Outdated
| @@ -2515,7 +2515,7 @@ | |||
| "label": "Cercle" | |||
| }, | |||
| "options__2": { | |||
| "label": "Carré" | |||
| "label": "Square" | |||
There was a problem hiding this comment.
Here as well. It's not consistent through that file. Sometimes it's good sometimes it isn't/
| @@ -728,7 +728,7 @@ | |||
| "label": "Retrato" | |||
| }, | |||
| "options__3": { | |||
| "label": "Quadrado" | |||
| "label": "Square" | |||
There was a problem hiding this comment.
Should probably not be square in this file either.
| @@ -610,7 +610,7 @@ | |||
| "label": "縱向" | |||
| }, | |||
| "options__3": { | |||
| "label": "正方形" | |||
| "label": "Square" | |||
|
🕐 This PR has been open for 9 days now 🕐 It is best to merge it as soon as possible in order to avoid having to deal with merge conflicts. More importantly, the content here really wants to reach production so everyone can benefit from it. It is your responsibility to merge this PR once you've reviewed it. 🙏 💚 |
|
🕐 This PR has been open for 11 days now 🕐 It is best to merge it as soon as possible in order to avoid having to deal with merge conflicts. More importantly, the content here really wants to reach production so everyone can benefit from it. It is your responsibility to merge this PR once you've reviewed it. 🙏 💚 |
|
Closing PR for now as per conversation with localization team. |
This PR modifies translations in the project. It will append multiple commits and may add, modify, or delete translations. Feel free to merge any time.
Before you deploy
Merge conflicts?
If this PR has been open long enough that it has drifted out of sync from the base branch and it has developed merge conflicts as a result, follow these steps, in order:
Translation Platform will recreate the translation commits based on the latest commit on the base branch and open a new PR.
Questions?
Visit #help-localization for questions about this pull request.
Translation component owners: @Shopify/themes-translations