You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// for a section id (e.g. 'template--22224696705326') and a section name (e.g. 'recommended-products'), return a qualified section id (e.g. 'template--22224696705326__recommended-products')
On Chrome Mobile 92.0.4515.90 on iPhone 12 (from Browserstack)
The text was updated successfully, but these errors were encountered:
uPesyLabs
changed the title
Critical errors on global.js script in old browser (<=2021) caused by # usage for private fields on SectionId class
Critical errors on global.js script in old browser (<=2021) caused by # usage for private fields on SectionId class
Aug 13, 2024
Describe the current behavior
On old browser, there is an error in
global.js
that prevent the script to be loaded successfully.Since it's a critical JS, with some functions used by other scripts, some other webcomponents doesn't work either.
Describe the expected behavior
No error when loading the
global.js
script.Version information (Dawn, browsers and operating systems)
Possible solution
Apparently it's caused by this new Class :
dawn/assets/global.js
Lines 9 to 26 in a22f8de
The fix is : Don't use this new feature of private field with
#
. Can be hardcoded directly or use a const instead.You can check the browser compatibility here : https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_properties#browser_compatibility
Additional context/screenshots
On Chrome Mobile 92.0.4515.90 on iPhone 12 (from Browserstack)
The text was updated successfully, but these errors were encountered: