Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

email-signup-banner.liquid: "templates" should be updated to "enabled_on" #3622

Open
jbrrrrr-abds opened this issue Sep 24, 2024 · 0 comments

Comments

@jbrrrrr-abds
Copy link

Describe the current behavior

Shopify CLI 'theme check' fails with 1 error when using the latest Dawn theme update.

Error:

─ info ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                                      │
│  sections/email-signup-banner.liquid                                                                                                 │
│                                                                                                                                      │
│                                                                                                                                      │
│  [error]: ValidSchema                                                                                                                │
│  Property templates is not allowed.                                                                                                  │
│                                                                                                                                      │
│  402  "templates": ["password"]

Describe the expected behavior

Shopify CLI 'theme check' should pass with no errors.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 15.1.0
  • Chromium Engine Version 129.0.6668.59
  • macOS Version 14.6.1
  • Shopify CLI Version: 3.67.1

Possible solution

The error is related to line 402 of sections/email-signup-banner.liquid. According to the section schema docs, using "templates" as a property is deprecated in favor of "enabled_on" and "disabled_on".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant