Make the ActiveSupport deprecator raise to ensure no deprecated behavior

This also removed the deprecated behavior of setting the behavior of the ActiveSupport::Deprecation singleton. Co-authored-by: Adrianna Chang <[email protected]>
Shopify · Nov 17, 2023 · 7903746 · 7903746
1 parent db5a2da
commit 7903746
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -10,6 +10,12 @@
 DeprecationToolkit::Configuration.test_runner = :rspec
 DeprecationToolkit::Configuration.deprecation_path = "spec/deprecations"
 
+if ActiveSupport.respond_to?(:deprecator)
+  ActiveSupport.deprecator.behavior = :raise
+else
+  ActiveSupport::Deprecation.behavior = :raise
+end
+
 RSpec.configure do |config|
   # Disable RSpec exposing methods globally on `Module` and `main`
   config.disable_monkey_patching!

diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -8,5 +8,9 @@
 require_relative "support/test_deprecator"
 require_relative "support/fake_rails"
 
-ActiveSupport::Deprecation.behavior = :silence
+if ActiveSupport.respond_to?(:deprecator)
+  ActiveSupport.deprecator.behavior = :raise
+else
+  ActiveSupport::Deprecation.behavior = :raise
+end
 ActiveSupport::TestCase.test_order = :random