Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disjunctive rollout-conditions #967

Open
timothysmith0609 opened this issue Nov 28, 2024 · 1 comment
Open

Support disjunctive rollout-conditions #967

timothysmith0609 opened this issue Nov 28, 2024 · 1 comment
Assignees
Labels
✨ enhancement Improvement or small feature

Comments

@timothysmith0609
Copy link
Contributor

Currently success conditions must ALL be true for a deploy to be considered successful. However, there are cases where different key-value combinations on the watched resource can indicate success/failure.

To accommodate this, let's allow rollout-conditions to be modelled as an array of an array of hash elements (currently it's an array of hash elements).

This keeps backwards compatibility and allows for more expressive conditions

cc @ryanvanhuuksloot

@timothysmith0609 timothysmith0609 added the ✨ enhancement Improvement or small feature label Nov 28, 2024
@timothysmith0609 timothysmith0609 self-assigned this Nov 28, 2024
@ivaliotes
Copy link

Needs done, but not immediately. Placing in Icebox for attention early in the new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement Improvement or small feature
Projects
None yet
Development

No branches or pull requests

2 participants