Optional fields encode when set #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the message:
message Color {
optional uint32 r = 1;
optional uint32 g = 2;
optional uint32 b = 3;
}
Color.new(r: 0, g: 0, b: 0).to_proto should produce "\b\x00\x10\x00\x18\x00" instead of "\b\x10\x18". Matches official google lib.
Also, linting and updating tests.
|
Verified VARINT,I64,I32 + Enums to produce the same as the official Google library. Checked by hand too, but need someone smarter than me to review carefully. The benchmark script isn't working for me anymore, but i doubt this'll add too much of a knock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting defaults on non-
optionalfields, it's fine to leave them out when encoding.For example, setting
falseon non-optional boolean or0(zero) on a numeric should not encode them.This is how the library currently works. Perfect.
Conversely, when setting a value on an
optionalfield, even if it's the default (0on numerics,falseon booleans), it should always encode the value and not leave it blank.Only when
optionaldoes not have an explicit value set, is it fine we leave it empty.Fixes #185