Skip to content

Commit

Permalink
šŸ§¹ Refactor Skia build scripts
Browse files Browse the repository at this point in the history
  • Loading branch information
wcandillon authored Oct 29, 2024
2 parents 25476d4 + 9309027 commit 4a2d7af
Show file tree
Hide file tree
Showing 12 changed files with 259 additions and 382 deletions.
1 change: 0 additions & 1 deletion packages/skia/android/cpp/jni/include/JniSkiaBaseView.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class JniSkiaBaseView {
}

protected:

virtual void surfaceAvailable(jobject surface, int width, int height) {
_skiaAndroidView->surfaceAvailable(surface, width, height);
}
Expand Down
1 change: 0 additions & 1 deletion packages/skia/android/cpp/jni/include/JniSkiaPictureView.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ class JniSkiaPictureView : public jni::HybridClass<JniSkiaPictureView>,
}

protected:

void surfaceAvailable(jobject surface, int width, int height) override {
JniSkiaBaseView::surfaceAvailable(surface, width, height);
}
Expand Down
7 changes: 2 additions & 5 deletions packages/skia/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,9 @@
"e2e": "E2E=true yarn test -i e2e",
"release": "semantic-release",
"build": "bob build && merge-dirs lib/typescript/src lib/commonjs && merge-dirs lib/typescript/src lib/module",
"build-skia-ios-framework": "ts-node ./scripts/build-skia-ios-framework.ts",
"build-skia-ios": "ts-node ./scripts/build-skia-ios.ts && yarn build-skia-ios-framework",
"build-skia-android": "ts-node ./scripts/build-skia-android.ts",
"clean-skia": "yarn rimraf ./libs && yarn rimraf ../../externals/skia/out",
"copy-skia-headers": "ts-node ./scripts/copy-skia-module-headers.ts",
"build-skia": "yarn rimraf ./libs && yarn build-skia-ios && yarn build-skia-android && yarn copy-skia-headers",
"build-skia": "ts-node ./scripts/build-skia.ts",
"copy-skia-headers": "ts-node ./scripts/copy-skia-headers.ts",
"clang-format": "yarn clang-format-ios && yarn clang-format-android && yarn clang-format-common",
"clang-format-ios": "find ios/ -iname '*.h' -o -iname '*.mm' -o -iname '*.cpp' | xargs clang-format -i",
"clang-format-android": "find android/cpp/ -iname '*.h' -o -iname '*.m' -o -iname '*.cpp' | xargs clang-format -i",
Expand Down
17 changes: 0 additions & 17 deletions packages/skia/scripts/build-skia-android.ts

This file was deleted.

59 changes: 0 additions & 59 deletions packages/skia/scripts/build-skia-ios-framework.ts

This file was deleted.

17 changes: 0 additions & 17 deletions packages/skia/scripts/build-skia-ios.ts

This file was deleted.

Loading

0 comments on commit 4a2d7af

Please sign in to comment.