Register common node handlers in parent class instead

Author: alexcrocha

lib/ruby_lsp/listeners/discover_tests.rb

@@ -21,10 +21,18 @@ def initialize(response_builder, global_state, dispatcher, uri)
 
         @fully_qualified_name = T.let("", String)
         @attached_ancestors = T.let([], T::Array[String])
+
+        dispatcher.register(
+          self,
+          :on_class_node_enter,
+          :on_class_node_leave,
+          :on_module_node_enter,
+          :on_module_node_leave,
+        )
       end
 
       #: (Prism::ClassNode node) -> void
-      def on_class_node_enter(node) # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
+      def on_class_node_enter(node)
         @visibility_stack << :public
         name = constant_name(node.constant_path)
         name ||= name_with_dynamic_reference(node.constant_path)
@@ -36,7 +44,7 @@ def on_class_node_enter(node) # rubocop:disable RubyLsp/UseRegisterWithHandlerMe
       end
 
       #: (Prism::ModuleNode node) -> void
-      def on_module_node_enter(node) # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
+      def on_module_node_enter(node)
         @visibility_stack << :public
 
         name = constant_name(node.constant_path)
@@ -46,13 +54,13 @@ def on_module_node_enter(node) # rubocop:disable RubyLsp/UseRegisterWithHandlerM
       end
 
       #: (Prism::ModuleNode node) -> void
-      def on_module_node_leave(node) # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
+      def on_module_node_leave(node)
         @visibility_stack.pop
         @nesting.pop
       end
 
       #: (Prism::ClassNode node) -> void
-      def on_class_node_leave(node) # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
+      def on_class_node_leave(node)
         @visibility_stack.pop
         @nesting.pop
       end

lib/ruby_lsp/listeners/spec_style.rb

@@ -15,25 +15,22 @@ def initialize(response_builder, global_state, dispatcher, uri)
 
         dispatcher.register(
           self,
-          :on_class_node_enter,
-          :on_class_node_leave,
-          :on_module_node_enter, # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
-          :on_module_node_leave, # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
+          # Common handlers registered in parent class
           :on_call_node_enter, # e.g. `describe` or `it`
           :on_call_node_leave,
         )
       end
 
       #: (node: Prism::ClassNode) -> void
-      def on_class_node_enter(node)
+      def on_class_node_enter(node) # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
         super
 
         is_spec = @attached_ancestors.include?("Minitest::Spec")
         @spec_class_stack.push(is_spec)
       end
 
       #: (node: Prism::ClassNode) -> void
-      def on_class_node_leave(node)
+      def on_class_node_leave(node) # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
         super
 
         @spec_class_stack.pop

lib/ruby_lsp/listeners/test_style.rb

@@ -141,18 +141,15 @@ def initialize(response_builder, global_state, dispatcher, uri)
 
         dispatcher.register(
           self,
-          :on_class_node_enter,
-          :on_class_node_leave, # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
-          :on_module_node_enter, # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
-          :on_module_node_leave, # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
+          # Common handlers registered in parent class
           :on_def_node_enter,
           :on_call_node_enter,
           :on_call_node_leave,
         )
       end
 
       #: (Prism::ClassNode node) -> void
-      def on_class_node_enter(node)
+      def on_class_node_enter(node) # rubocop:disable RubyLsp/UseRegisterWithHandlerMethod
         super
 
         @framework_tag = :test_unit if @attached_ancestors.include?("Test::Unit::TestCase")