Apply linter corrections

Author: iandelahorne

test/adapters/activerecord_trilogy_adapter_test.rb

@@ -413,7 +413,7 @@ def test_circuit_open_errors_do_not_trigger_the_circuit_breaker
           end
           error = Semian[:mysql_testing].circuit_breaker.last_error
 
-          assert_equal(ActiveRecord::ConnectionNotEstablished, error.class)
+          assert_instance_of(ActiveRecord::ConnectionNotEstablished, error)
         end
       end
 

test/instrumentation_test.rb

@@ -52,7 +52,7 @@ def test_success_instrumentation_wait_time
     subscription = Semian.subscribe do |*_, wait_time|
       hit = true
 
-      assert(wait_time.is_a?(Integer))
+      assert_kind_of(Integer, wait_time)
     end
     Semian[:testing].acquire {}
 

test/lru_hash_test.rb

@@ -179,7 +179,7 @@ def test_monotonically_increasing
       previous_timestamp = start_time
 
       lru_hash.keys.zip(lru_hash.values).each do |key, val|
-        assert(val.updated_at > previous_timestamp, "Timestamp for #{key} was not monotonically increasing")
+        assert_operator(val.updated_at, :>, previous_timestamp, "Timestamp for #{key} was not monotonically increasing")
       end
     end
 

test/resource_test.rb

@@ -42,7 +42,7 @@ def test_initialize_with_float
   end
 
   def test_max_tickets
-    assert(Semian::MAX_TICKETS > 0)
+    assert_operator(Semian::MAX_TICKETS, :>, 0)
   end
 
   def test_register

test/time_helper_test.rb

@@ -10,7 +10,7 @@ def test_time_monotonic_travel_past
       current = Process.clock_gettime(Process::CLOCK_MONOTONIC)
     end
 
-    assert(now > current, "now #{now} should be bigger than current #{current}")
+    assert_operator(now, :>, current, "now #{now} should be bigger than current #{current}")
   end
 
   def test_time_monotonic_travel_future
@@ -20,7 +20,7 @@ def test_time_monotonic_travel_future
       current = Process.clock_gettime(Process::CLOCK_MONOTONIC)
     end
 
-    assert(now + 5 < current, "now #{now} should be less than current #{current} at least by 5 secs")
+    assert_operator(now + 5, :<, current, "now #{now} should be less than current #{current} at least by 5 secs")
   end
 
   def test_time_travel_past
@@ -30,7 +30,7 @@ def test_time_travel_past
       current = Time.now
     end
 
-    assert(now > current, "now #{now} should be bigger than current #{current}")
+    assert_operator(now, :>, current, "now #{now} should be bigger than current #{current}")
   end
 
   def test_time_travel_future
@@ -40,6 +40,6 @@ def test_time_travel_future
       current = Time.now
     end
 
-    assert(now + 5 < current, "now #{now} should be less than current #{current} at least by 5 secs")
+    assert_operator(now + 5, :<, current, "now #{now} should be less than current #{current} at least by 5 secs")
   end
 end