Remove the with keyword

[KevinGrandon]

WHY are these changes introduced?

This repository currently uses the with keyword when importing JSON. This keyword is deprecated and causes problems on the latest LTS node versions in strict mode.

WHAT is this pull request doing?

Remove the with keyword as it is not needed.

Type of change

• [x ] Patch: Bug (non-breaking change which fixes an issue)
• Minor: New feature (non-breaking change which adds functionality)
• Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
• I have added/updated tests for this change
• I have documented new APIs/updated the documentation for modified APIs (for public APIs)

[matteodepalo]

Hi @KevinGrandon, thank you for opening this PR. Have you considered what @lizkenyon described here? Does it not apply anymore?

[KevinGrandon]

Thanks for the comment @matteodepalo and the previous fix @lizkenyon. I am having issues updating my Shopify app to node 20 due to this statement. I'm guessing this is not an issue here because there are no remix tests that run on node 20 in CI? As far as I can tell dropping it should be fine. Here's a comparison of the built file in main vs this PR:

Main:

With this PR:

[matteodepalo]

I've just tried it in a new app and it seems to be broken.

[matteodepalo]

You have to use one of the following node versions: ^18.20 || ^20.10 || >=21.0.0

[KevinGrandon]

@matteodepalo Thank you - could you give me steps on the best way to reproduce this failure? I'm happy to work through it.

[matteodepalo]

@KevinGrandon sure, I:

• Cloned the shopify-app-js repo
• Checked out your PR
• Run pnpm build
• Created a new app
• Run pnpm add "file:/<your-path>/shopify-app-js/packages/apps/shopify-app-remix" -w"
• Run pnpm shopify app dev