Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auth for partner "owners" when profiling storefronts #151

Closed
ginagregory opened this issue Oct 30, 2024 · 8 comments
Closed

Support auth for partner "owners" when profiling storefronts #151

ginagregory opened this issue Oct 30, 2024 · 8 comments

Comments

@ginagregory
Copy link

I've had a long-standing issue with being able to use this extension. I suspect it is an authentication issue. I've always had a Shopify account connected to a Partner account.

I am listed as an "Owner" (among many others at our company) in the "Team" page in our Partner Portal.

I've tried to use this extension on numerous stores of different types and it's never worked for me with this type of account.

@bansavage
Copy link

It's broken (again)

@Alopwer
Copy link

Alopwer commented Jan 20, 2025

It's still broken

@mgmanzella mgmanzella changed the title This page cannot be profiled error Support auth for partner "owners" when profiling storefronts Jan 22, 2025
@mgmanzella
Copy link
Contributor

👋 @Alopwer @bansavage "This page cannot be profiled error" should be resolved with the newly released version (3.0.0) of the theme inspector

@ginagregory i'll be renaming this issue as a request to support this kind of account for auth when profiling, I suspect you don't have the correct permissions. you can DM me at Morisa Manzella on the partner slack with your name and store you're trying to profile for me to confirm

@0x15f
Copy link

0x15f commented Jan 22, 2025

👋 @Alopwer @bansavage "This page cannot be profiled error" should be resolved with the newly released version (3.0.0) of the theme inspector

@ginagregory i'll be renaming this issue as a request to support this kind of account for auth when profiling, I suspect you don't have the correct permissions. you can DM me at Morisa Manzella on the partner slack with your name and store you're trying to profile for me to confirm

@mgmanzella The authentication process is still a bit painful, many of us have partner accounts and also have direct access to some stores. With the default sign in process on Shopify I end up in scenarios all the time where I am using the right email and the wrong account and then have to sign into the correct account to access a store. It would be immensely helpful to show more info in this section, maybe the partner account name/id, or the email/store I am currently signed into if its not a partner account.

Image

@Alopwer
Copy link

Alopwer commented Jan 22, 2025

👋 @Alopwer @bansavage "This page cannot be profiled error" should be resolved with the newly released version (3.0.0) of the theme inspector

@ginagregory i'll be renaming this issue as a request to support this kind of account for auth when profiling, I suspect you don't have the correct permissions. you can DM me at Morisa Manzella on the partner slack with your name and store you're trying to profile for me to confirm

Nice, thanks. But I started using new shopify-cli profile feature which also works well.

@madmath
Copy link
Contributor

madmath commented Jan 22, 2025

It would be immensely helpful to show more info in this section, maybe the partner account name/id, or the email/store

@0x15f version 3.0.2 should be published soon (once #155 is reviewed by the Chrome Store). It shows the email in the auth popup. Unfortunately this is all the information available in that login credential.

@bansavage
Copy link

I had to uninstall and redownload the new Chrome extension. Confirming it is working, albeit with an unexpected UI/devtooling change.

@madmath @mgmanzella

  1. What are you plans to ensure this stays maintained and will not lapse into decay like the previous iteration?
  2. Also when can we expected updated docs on the tool?
    https://shopify.dev/docs/storefronts/themes/tools/theme-inspector/using-the-theme-inspector

@benjaminsehl
Copy link
Member

benjaminsehl commented Jan 23, 2025

  1. What are you plans to ensure this stays maintained and will not lapse into decay like the previous iteration?

We've kept this as lean as we could to make maintenance easier, one key part here was using Speedscope under the hood instead of building our own UI … which is why you're seeing that UI change.

  1. Also when can we expected updated docs on the tool?
    https://shopify.dev/docs/storefronts/themes/tools/theme-inspector/using-the-theme-inspector

Mathieu has a PR in and should be shipped later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants