Merge pull request #1774 from Shopify/andyw8/remove-net-smtp-dependency

Remove `net-smtp` dependency
Shopify · Jan 24, 2024 · 57e2c6b · 57e2c6b
2 parents 16c9489 + 9a7bdde
commit 57e2c6b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/Gemfile b/Gemfile
@@ -43,11 +43,6 @@ group :development, :test do
   gem "bcrypt", require: false
   gem "xpath", require: false
   gem "kredis", require: false
-
-  # net-smtp was removed from default gems in Ruby 3.1, but is used by the `mail` gem.
-  # So we need to add it as a dependency until `mail` is fixed:
-  # https://github.com/rails/rails/blob/0919aa97260ab8240150278d3b07a1547489e3fd/Gemfile#L178-L191
-  gem "net-smtp", "0.4.0.1", require: false
 end
 
 group :test do

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -432,7 +432,6 @@ DEPENDENCIES
   minitest
   minitest-hooks
   minitest-reporters
-  net-smtp (= 0.4.0.1)
   nokogiri
   pry
   pry-byebug