Skip validating RBIs when running under add-on mode #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RBI validation is to prevent conflicts between gem RBIs and DSL RBIs coming from those gems. That scenario is not relevant for the add-on because the user would only be editing files like models and not files inside gems
KaanOzkan
approved these changes
Nov 22, 2024
vinistock
merged commit c3a7376
into
tapioca-addon-feature-branch
29 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The RBI validation is to prevent conflicts between gem RBIs and DSL RBIs coming from those gems. That scenario is not relevant for the add-on because the user would only be editing files like models and not files inside gems.
That scenario is more important for when you're bumping a gem manually, but that's not covered by the add-on and I think it should be fine to not validate the RBIs.
The reason this is relevant is because to validate them, we shell out to Sorbet, which consumes more than 2x the amount of time it takes to actually generate the DSL RBIs.
Implementation
Simply started skipping validation when in add-on mode.