[Tapioca Add-on] Implement boilerplate add-on code #2088
Merged
+13,904
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vinicius Stock <[email protected]> Co-authored-by: Andy Waite <[email protected]>
vinistock
approved these changes
Nov 22, 2024
KaanOzkan
commented
Nov 22, 2024
| @@ -45,6 +45,8 @@ Sorbet/TrueSigil: | |||
| Include: | |||
| - "**/*.rb" | |||
| - "**/*.rake" | |||
| Exclude: | |||
| - "lib/ruby_lsp/tapioca/server_addon.rb" | |||
There was a problem hiding this comment.
Following the discussion on Shopify/ruby-lsp-rails#469 (comment)
| @@ -25,9 +25,6 @@ class Source < URI::File | |||
| # have the uri gem in their own bundle and thus not use a compatible version. | |||
| PARSER = T.let(const_defined?(:RFC2396_PARSER) ? RFC2396_PARSER : DEFAULT_PARSER, RFC2396_Parser) | |||
|
|
|||
| alias_method(:gem_name, :host) | |||
| alias_method(:line_number, :fragment) | |||
There was a problem hiding this comment.
Causes re-definition error for source URI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Extracting from main...tapioca-addon-feature-branch. Commits are edited from the originals to make the boilerplate up to date.
Implementation
Tests
Rails add-on already tests the add-on API so I don't think it's necessary