Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings.type bug fix #611

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

settings.type bug fix #611

wants to merge 1 commit into from

Conversation

navdeep5
Copy link
Contributor

@navdeep5 navdeep5 commented Nov 20, 2024

What are you adding in this PR?

Resolves #605 and #608

This PR is meant to ensure that checks do not blow up existent themes. To do so, we are adding preliminary checks to make sure that we are only using theme blocks, and if so, proceed with the checks.

What's next? Any followup issues?

There are a couple directions in which we can follow up with this issue.

  1. Right now, we are only checking preset blocks at the first level (not nested levels). The reason being is that nested preset checks will require cross file validation which would we should follow up on.
  2. Once content with these changes, worthwhile to change the check recommendations to true.

What did you learn?

I learned about the difference between how older and newer (with theme block) themes are written, as well as more information about nested preset blocks and how their validation needs to occur.

Before you deploy

  • This PR includes a new checks or changes the configuration of a check
    • I included a minor bump changeset
    • It's in the allChecks array in src/checks/index.ts
    • I ran yarn build and committed the updated configuration files
      • If applicable, I've updated the theme-app-extension.yml config
  • I included a minor bump changeset
  • My feature is backward compatible
  • I included a patch bump changeset

@navdeep5 navdeep5 force-pushed the navdeep-block-target-bug branch 2 times, most recently from 70c608b to 1088897 Compare November 21, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidBlock throwing false positives
1 participant