Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Resolves #605 and #608
This PR is meant to ensure that checks do not blow up existent themes. To do so, we are adding preliminary checks to make sure that we are only using theme blocks, and if so, proceed with the checks.
What's next? Any followup issues?
There are a couple directions in which we can follow up with this issue.
What did you learn?
I learned about the difference between how older and newer (with theme block) themes are written, as well as more information about nested preset blocks and how their validation needs to occur.
Before you deploy
changeset
allChecks
array insrc/checks/index.ts
yarn build
and committed the updated configuration filestheme-app-extension.yml
configchangeset
changeset