Merge pull request #2434 from Shopify/fix-return-type

Fix render extension return type
Shopify · Oct 24, 2024 · 94609d5 · 94609d5
2 parents f041b7d + 82991cd
commit 94609d5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.changeset/unlucky-cycles-invite.md b/.changeset/unlucky-cycles-invite.md
@@ -0,0 +1,6 @@
+---
+'@shopify/ui-extensions': patch
+---
+
+Fix return type for RenderExtension to optionally return a clean up function
+Remove unused RunnableExtension interface for Admin
diff --git a/packages/ui-extensions/src/surfaces/admin/registration.ts b/packages/ui-extensions/src/surfaces/admin/registration.ts
@@ -1,9 +1,5 @@
 export interface RenderExtension<Api> {
-  (root: HTMLElement, api: Api): Promise<() => void>;
-}
-
-export interface RunnableExtension<Api, Output> {
-  (api: Api): Output | Promise<Output>;
+  (root: HTMLElement, api: Api): Promise<void | (() => void)>;
 }
 
 export interface ExtensionRegistrationFunction<ExtensionTargets> {