-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POS UI Extensions - Extension is not Full Screen as Expected #2414
Comments
is just saw that this could be a feature and not a bug, depending on what you mean as Because, what is being rendered is NOT a Modal, its a fully featured extension, and it is benefiting greatly from being a full screen extension.If you think this should be a feature at least provide the option to be full screen or windowed as a prop. This kind of visually breaking changes with no way to circumvent them, and no backwards compatibility, is not cool. If I want to use the 2024-10 version now, I can't, because everything shrinks to %50 of its size for the whole extension horizontally...... |
@jamesvidler ??? |
@xqwtsz sorry for the late reply here, POS on iOS is now using sheet modals, it's an app wide design change. We did version this to 2024-10 and up, so on 2024-07 it would still be full screen, as we did not want to break existing extensions on older versions. But by updating to 2024-10, on iOS it will now be in a modal sheet. This is a POS wide change, and more in line with the iOS platform, not just a UI Extension change. You'll notice that on Android it's still full screen. Apologies for the inconvenience. |
@js-goupil after 1.5 months you just replied with what I already wrote and no other info. Is there any plans to make it optional/property? It's a huge change in terms of screen real estate and the current extensions were not created to fit inside small modals in the first place. and why would they be? There was no sign of a change like this coming. Upgrading to use the latest version will now require a lot of effort just to try and make things fit, not to mention the user feedback after everything is HALF THE WIDTH. And it doesn't really matter if its full screen on android, unless you're buying us all new android tablets for all of our POS locations?? |
moved to the forums |
Please list the package(s) involved in the issue, and include the version you are using
Also
in the
shopify.extension.toml
Describe the bug
The
Modal
component that is with the target:is rendering as a modal, and is NOT full screen as expected.
Steps to reproduce the behavior:
api_version
in theshopify.extension.toml
to2024-07
npm run dev
, everything is full screen, as expected.api_version
in theshopify.extension.toml
to2024-10
npm run dev
, modals look like modals and are not full screen.Expected behavior
Expect the Modal to be full screen.
Screenshots
shopify.extension.toml
- API Version - 2024-07 - Expectedshopify.extension.toml
- API Version - 2024-10 - BrokenThe text was updated successfully, but these errors were encountered: