Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove artificial restriction for file suffixes #52

Open
dharabor opened this issue Sep 29, 2024 · 0 comments
Open

Remove artificial restriction for file suffixes #52

dharabor opened this issue Sep 29, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dharabor
Copy link
Member

dharabor commented Sep 29, 2024

When uploading a trace, the app demands a specific kind of suffix. Suggest to remove this check and instead parse whatever input file the user specifies. If the input is malformed, throw a parsing error with additional information.

My reasoning is threefold:

(1) The restriction is artificial and creates additional doubt and friction for first-time users, who are probably just looking to work with output from a solver (e.g., piglet).

(2) Asking for specific suffixes makes sense for binary files (maybe) but less so for structured text files, where we can check every line of input.

(3) Throwing an error to say something is wrong gives us an opportunity to link the user to documentation sources, which explain valid input looks like.

@dharabor dharabor added the bug Something isn't working label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants