Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPS Node ID Size and Direction Issue #1

Open
heavenfall opened this issue Nov 14, 2024 · 0 comments
Open

JPS Node ID Size and Direction Issue #1

heavenfall opened this issue Nov 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@heavenfall
Copy link
Collaborator

JPS 2+ expansion policy is set to encode the direction into the node_id value;

jps_id stores the node id value used in jps algorithms as a uint32_t (32-bit unsigned). The current implementation for this version stores the direction into the id values on the MSB of the uint32_t value.

This restricts the id values on maps to 2^24 max, around 2^12 x 2^12 or 4096x4096 maximum dimensions, smaller than some maps used in iron harvest benchmarks.

Propose discussion on how to solve this issue, including either:

  • Widening jps_id
  • Rewrite
@heavenfall heavenfall added the bug Something isn't working label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant