Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter, formatter の追加 #81

Merged

Conversation

soooku
Copy link
Collaborator

@soooku soooku commented Jul 18, 2024

Issue

close #71

やったこと

  • ruff をGitHub workflowに入れる

参考記事、使い方など以下にまとめました。
https://scrapbox.io/42-ft-transcendence/python_formatter_&_linter

@soooku soooku marked this pull request as ready for review July 20, 2024 07:31
Copy link
Collaborator

@massahito massahito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@subarunrun0812 subarunrun0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

正常にコンテナを立てれた。
寿司ゆき:yes

@subarunrun0812
Copy link
Collaborator

smiling-bill-gates

- uses: actions/checkout@v4
- uses: chartboost/ruff-action@v1
with:
args: 'format --check'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ファイルの末尾は空行が入るようにしてほしいかもー
参考: https://qiita.com/hamacccccchan/items/11c17c7412a5aeb2ad74

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github上での設定のために、ruffname: syntax-check-pythonを追加して欲しい

Copy link
Owner

@ShotaTanemura ShotaTanemura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pong/ruff.toml Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このファイルも末尾に空行なかった

@ShotaTanemura ShotaTanemura merged commit fca2776 into develop Jul 20, 2024
1 check passed
@ShotaTanemura ShotaTanemura deleted the refactor/71-add-linter-and-formatter-for-python branch July 20, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter or formatter 入れる
4 participants