Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini music player improvement #124

Open
3 tasks done
umuieme opened this issue Jan 9, 2017 · 5 comments
Open
3 tasks done

mini music player improvement #124

umuieme opened this issue Jan 9, 2017 · 5 comments
Assignees

Comments

@umuieme
Copy link
Contributor

umuieme commented Jan 9, 2017

  • show only title and play/pause at first

  • show image for podcast on mini player

  • show seekbar when click on mini player

@rakeeb11 rakeeb11 self-assigned this Jan 10, 2017
@rakeeb11 rakeeb11 changed the title Mini music player issue mini music player improvement Jan 10, 2017
@benloks
Copy link

benloks commented Jan 21, 2017

@rakeeb11 there are other issues still remaining with the mini media player:

  • after playing audio post (not radio), player does not stay open when pressing "back"
  • if audio post is playing, not able to start playing radio episode until you close the player.

@rakeeb11
Copy link

will have a look at it ASAP

@rakeeb11
Copy link

@benloks I've solved the first issue, but could not reproduce the second issue you mentioned.

@benloks
Copy link

benloks commented Jan 24, 2017

@rakeeb11 sorry it's difficult for me to test right now because I am shaky wifi. You may be right about the second issue.
But could you take a look at the radio player again? It seems like there might be other problems with it - though maybe you already solved them. E.g. in the build I have installed, I cannot select a radio episode to play... it just auto-plays the first one and selecting other episodes does not work. Please confirm if this is reproducible.

@rakeeb11
Copy link

@benloks you're experiencing this because of the shaky internet.

The way the media player is built right now does not acknowledge user selection right away, it waits for the device to load all the necessary information it needs to play the podcast.

I'll tweak this process so that the user selection is acknowledged right away.

Thanks Ben.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants