Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The screen need to have slug for URL #39

Open
tyohan opened this issue Jan 26, 2017 · 6 comments
Open

The screen need to have slug for URL #39

tyohan opened this issue Jan 26, 2017 · 6 comments

Comments

@tyohan
Copy link
Contributor

tyohan commented Jan 26, 2017

@prashantsh The API for screens list only use integer to refer it. On web we need to have it friendly url. So we need slug version of URL instead of integer. So on the web app we can create a menu like /screen/applying-to-go-aboard instead /screen/1. It must be latin, lowercase, alphanumeric only plus - character. It should be editable through screen form creation but automatically filled from title like WordPress post creation.

@prashantsh
Copy link

@mojbenzcar Can you have a look at it.

@tyohan
Copy link
Contributor Author

tyohan commented Jan 27, 2017

@mojbenzcar any update on this? cc @prashantsh

@mojbenzcar
Copy link
Contributor

Please check api. Slugging title will work fine with English language but slugging Nepali (Unicode) may not works as expected. @tyohan How to tackle slugging url with Unicode title. cc @prashantsh

@mojbenzcar
Copy link
Contributor

@tyohan has been fixed please check api link and FYI i have changed share url of post to AMP version url.

@mojbenzcar
Copy link
Contributor

cc @prashantsh

@tyohan
Copy link
Contributor Author

tyohan commented Jan 29, 2017

Thanks @mojbenzcar. I understand that Nepali title could be a problem on url so that's why we should able to make it work either through screen id or slug url. And we can let user input the slug url in edit screen. One thing, we need to filter the input on cms to not allow other than lowercase alphanumerics plus - characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants