Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressing images manually #41

Open
Yash-Ainapure opened this issue Dec 18, 2023 · 21 comments
Open

Compressing images manually #41

Yash-Ainapure opened this issue Dec 18, 2023 · 21 comments
Labels
Easy easy level issue enhancement Enhancing existing feature SWOC S4 Assigned to SWOC S4 Contributor up for grabs open to contributors

Comments

@Yash-Ainapure
Copy link
Contributor

while cloning the project images has larger sizes which makes the contributor download all the images .
Solution to it is compressing it manually or uploading it on a database storage.
Image below shows the present size of images total is - 376 MB

Screenshot (133)

@ShwetKhatri2001
Copy link
Owner

Good find. I personally faced this issue. Better if the images can be hosted somewhere for free and can be used as urls directly. If not, then compression of images is required.

@Yash-Ainapure
Copy link
Contributor Author

yeah

Good find. I personally faced this issue. Better if the images can be hosted somewhere for free and can be used as urls directly. If not, then compression of images is required.

yess

@Yash-Ainapure
Copy link
Contributor Author

Good find. I personally faced this issue. Better if the images can be hosted somewhere for free and can be used as urls directly. If not, then compression of images is required.

@ShwetKhatri2001 I would like to host it on firebase, but for that i need your(owner's) email id and use that for firebase account.
we can contact on discord for that

@Yash-Ainapure
Copy link
Contributor Author

@ShwetKhatri2001 ,any updates on this ? . I would like to compress images and again push to this repo , but this is too much work as there are so much images.
Could you just consider this issue as hard please.

@ShwetKhatri2001
Copy link
Owner

You can simply compress and replace them using few free resources such as https://tinypng.com/.
It can be considered as medium level issue at max since it will not be involving any kind of coding.
Let me know if you'd like to work on this.

@Yash-Ainapure
Copy link
Contributor Author

You can simply compress and replace them using few free resources such as https://tinypng.com/. It can be considered as medium level issue at max since it will not be involving any kind of coding. Let me know if you'd like to work on this.

let this issue be open then , if someone want to work they can.

@ShwetKhatri2001 ShwetKhatri2001 added enhancement Enhancing existing feature Medium medium level issue up for grabs open to contributors labels Dec 20, 2023
@SadanandMiskin
Copy link

Hey @ShwetKhatri2001 ,I would Like to work on this issue , Can u assign me under SWOC'24

@ShwetKhatri2001
Copy link
Owner

Okay go ahead, You're assigned.

@ShwetKhatri2001 ShwetKhatri2001 added Easy easy level issue SWOC S4 Assigned to SWOC S4 Contributor and removed Medium medium level issue up for grabs open to contributors labels Jan 1, 2024
@SadanandMiskin
Copy link

@ShwetKhatri2001 I went through the songs-image folder , The maximum size of that folder is due to the audio files (.mp3) ,The image files are not much in size.
So I guess the issue lies with compressing of audio files not images.

EXAMPLE-
songs-images/TopBollywoodHits -> mp3 file size is more than image

image

@ShwetKhatri2001
Copy link
Owner

Any easy to implement solution you have in mind for that ? Compressing audio files may work as well.
The motive is to reduce the size of the project without disturbing the functionality.

@JoydeepMallick
Copy link
Contributor

Any easy to implement solution you have in mind for that ? Compressing audio files may work as well. The motive is to reduce the size of the project without disturbing the functionality.

@ShwetKhatri2001 I would like to compress the audio files so as to reduce the overall project size, on bit of research I find of reducing the bit rate can reduce size of files significantly but need to keep in mind not to reduce too much which will lead to loss of sound quality and a strange humming sound getting added.

Sample without compression (~5mb):-

001.Brishti.Tomake.Dilam.2.mp4

Sample with extreme compression(~1mb, 32kbps bit rate) -- sound gets a little strange melody reduced, this song seems to point out the fact more maybe due to some particular sound element(😅note : I am not into music)

001.Brishti.Tomake.Dilam.mp4

Sample with okok sound (~4mb, 128kbps bit rate) -- sounds decent to me

001.Brishti.Tomake.Dilam45.mp4

I would like to work on audio file size issue and compress them as much as possible without losing quality in songs-images folder under SWOC 24 project contribution if you assign this issue to me. Hope my above idea will reduce the file size if not much but considerable amount.

Maybe at a later stage we can simply host all music in a remote server and then inside the swetify.js we can just add links to music and they will play, only keeping the images in folder in github would be enough then I guess.

@ShwetKhatri2001
Copy link
Owner

Let's keep it like this. Keep this issue for compressing images only to be solved by @SadanandMiskin .
@JoydeepMallick you can raise a new issue with such a description for compressing audio files. I'll assign you that.

@JoydeepMallick
Copy link
Contributor

Let's keep it like this. Keep this issue for compressing images only to be solved by @SadanandMiskin . @JoydeepMallick you can raise a new issue with such a description for compressing audio files. I'll assign you that.

As mentioned @ShwetKhatri2001 sir I have opened a new issue here instead regarding this.

@SadanandMiskin
Copy link

Any easy to implement solution you have in mind for that ? Compressing audio files may work as well.
The motive is to reduce the size of the project without disturbing the functionality.

@ShwetKhatri2001 you can assign this issue to @JoydeepMallick .

@Yash-Ainapure
Copy link
Contributor Author

@ShwetKhatri2001 , Making such changes is good but won't work for longer duration. why not create a database and push all the things there. (there are many free databases so this won't charge anything to you ).

Let others first compress it and then we could put it on database . what do you think about this??

@ShwetKhatri2001
Copy link
Owner

Sure, will do this later.

@ShwetKhatri2001
Copy link
Owner

@SadanandMiskin can't you just compress the images being used on our website?

@SadanandMiskin
Copy link

@ShwetKhatri2001 , Making such changes is good but won't work for longer duration. why not create a database and push all the things there. (there are many free databases so this won't charge anything to you ).

Let others first compress it and then we could put it on database . what do you think about this??

@Yash-Ainapure and also using only database is not a good option , as if you request for a particular song ,server will fetch that whole song till that no music will be played, so there the application becomes slow ,, to avoid it you need to build something which Fetches a song in real-time like webRTC so that it doesn't make website slow.

@SadanandMiskin
Copy link

@SadanandMiskin can't you just compress the images being used on our website?

That's already is very low size , like 50kb - 60kb , if you compress more the images will break,

@Yash-Ainapure
Copy link
Contributor Author

@ShwetKhatri2001 , Making such changes is good but won't work for longer duration. why not create a database and push all the things there. (there are many free databases so this won't charge anything to you ).
Let others first compress it and then we could put it on database . what do you think about this??

@Yash-Ainapure and also using only database is not a good option , as if you request for a particular song ,server will fetch that whole song till that no music will be played, so there the application becomes slow ,, to avoid it you need to build something which Fetches a song in real-time like webRTC so that it doesn't make website slow.

I don't know whether webRTC is used for that purpose. but we can store that specific song in local storage/cache memory.
I don't think it will slow down the website as the songs aren't larger than 5mb per song. we can make a logic for that to so download specific song only not the all list of songs at a time

@SadanandMiskin
Copy link

@Yash-Ainapure am not telling to use webrtc ,, but something like that,

@ShwetKhatri2001 ShwetKhatri2001 added the up for grabs open to contributors label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy easy level issue enhancement Enhancing existing feature SWOC S4 Assigned to SWOC S4 Contributor up for grabs open to contributors
Projects
None yet
Development

No branches or pull requests

4 participants