Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Heaters out with simple TE and TM MZI circuits #3

Merged
merged 6 commits into from
Jul 14, 2024

Conversation

boy4429856821
Copy link
Contributor

No description provided.

@boy4429856821
Copy link
Contributor Author

boy4429856821 commented May 23, 2024

only concern that I think is a problem is having multiple ports labels on the heaters (for example, elec_TEMZIa_G and elec_TEMZIb_G). Is this okay? I want to take repeatability measurements and this is the only way I could think of.... Let me know your thoughts

@mustafacc
Copy link
Member

@JymBone5

@JymBone5
Copy link
Contributor

JymBone5 commented May 23, 2024

That should be okay, but each electrical pad is associated to the corresponding device by the name you give it, it must be the same as the device name in order for it to be linked, you can label multiple electrical pads but must provide the correct associated device, if you label multiple you can name them using the last field so G and G_1 for instance

@boy4429856821
Copy link
Contributor Author

yup, I believe I have that correct in this design.

@boy4429856821
Copy link
Contributor Author

boy4429856821 commented May 23, 2024

Also, I'm sort of confused about the creating the .yaml file for this design. Where can I find the .exe file that allows me to create the TestParameters yaml file?

@lukasc-ubc
Copy link
Member

Good timing. We just updated the instructions and the Yaml creator:

Details on the Yaml SiEPIC test creator GUI

@lukasc-ubc
Copy link
Member

Could you please create the Yaml file and upload together with the layout?

@boy4429856821
Copy link
Contributor Author

boy4429856821 commented May 26, 2024

Good timing. We just updated the instructions and the Yaml creator:

Details on the Yaml SiEPIC test creator GUI

Hi @lukasc-ubc , I tried the yaml_testcreator but it's having issues extracting electrical coordinates, even for the example in the GITHUB repo. Can you check to see if this is reproduced on your end? Also is there a feature request page for this tool? For example, a clear output log button would be nice :)
image

@lukasc-ubc
Copy link
Member

To make feature requests / bugs, can you please use this? https://github.com/SiEPIC/SiEPIC_testcreator/issues

I reported it: SiEPIC/SiEPIC_testcreator#9

@PetervandenDoel
Copy link
Contributor

@boy4429856821 Can you try labelling your electrical pad names without the _G at the end?

@boy4429856821
Copy link
Contributor Author

boy4429856821 commented Jun 15, 2024

unsure what the errors are.... Was able to make properly make a YAML file thanks to Peter :)

@lukasc-ubc
Copy link
Member

You only have one opt_in label, but two separate optical circuits. Only one of them will be measured (the top one). Please add.

@lukasc-ubc lukasc-ubc added the bug Something isn't working label Jul 14, 2024
@boy4429856821
Copy link
Contributor Author

boy4429856821 commented Jul 14, 2024

Hi @lukasc-ubc , I think my files are passing DRC and layout verification but there are some other files that were submitted but other users that are causing errors? Please let me know.

image

@lukasc-ubc
Copy link
Member

Great!

@lukasc-ubc lukasc-ubc merged commit dee158a into SiEPIC:main Jul 14, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants