Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test yaml file and updated opt labels #53

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

FaresBadrCA
Copy link
Contributor

Changed grating label prefix from opt_in_ to opt_
Remaining errors:

  • "Shapes outside component" due to heater not having a device recognition layer
  • "Devices cannot be overlapping" due to metal routing layer intersecting with waveguide
  • "Si_Width" due to adiabatic coupler having a taper which is finer than the minimum feature size.

There are no plans to resolve these issues - this submission is intended for fabrication as-is.

Changed grating label prefix from opt_in_ to opt_
Remaining errors:
- "Shapes outside component" due to heater not having a device recognition layer
- "Devices cannot be overlapping" due to metal routing layer intersecting with waveguide
- "Si_Width" due to adiabatic coupler having a taper which is finer than the minimum feature size. 

There are no plans to resolve these issues - this submission is intended for fabrication as-is.
YAML test file was prefixed with 'Ebeam', but GDS file was prefixed with 'EBeam'. Fixed by changing the YAML file name prefix to 'EBeam' to match the GDS file.
@lukasc-ubc
Copy link
Member

For next time:

  • please put all shapes in a cell. There is a wg_heater PCell in the library for this purpose.
image

@lukasc-ubc lukasc-ubc merged commit 7d0cdc2 into SiEPIC:main Jul 14, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants